Interfaces Review Results: Part2
From KDevelop
52) isn't VcsJob an interface because it does not really provides
any implementation at all?
53) we need an instructions what to do with a job
54) edit/unedit might have default implementation or moved to
separate interface because the class doc's contract says
we need to implement all methods in the IBasicVersionControl
interface
55) use KUrl::List in IBasicVersionControl::edit/unedit
56) no distinction between vcs command results and errors
57) it's not clear how to use the interfaces and what is the
purpose of their existance
58) do we need defaults for RecursionMode in version control ifaces?
59) invalid VcsRevision if default constructor is used
60) replace 2 methods foo and showFoo() with one and additional argument?
61) s/show/interactive?
62) figure out in vcs plugin whether to use gui thread or run op
in the separate thread
63) mail aaa.txt and explain why
64) VcsDiff::type must die in IBasicVersionControl::diff
65) get rid of VcsDiff::Type because the vcs plugin will return
2 files for binary diff and unified for text files
66) pull = fetch + merge and we need to have that in the iface
67) checkout() does not really belong to IBasicVersionControl
- move checkout() to ICentralizedVersionControl
68) find out what vcs mapping is (lingers in the mail archives)
69) why does diff() and merge() have QVariant for locations,
whereas VcsMapping and clone() only have QString?
70) figure out a way to checkout and merge with specifying
branches (maybe in the VCSMapping)